docs: clarify region requirement for S3-compatible endpoints#851
Merged
Conversation
Member
|
Hi @davidmyriel, the PR looks good overall I had one small suggestion around the wording for the
Rest of the changes look great |
Member
|
@davidmyriel can you pls resolve the conflicts so that we can close this |
- Add Tigris to the list of S3-compatible providers - Note that region: 'auto' applies to MinIO, R2, and Tigris (these services don't expose AWS-style regions; the value is still required for request signing but the service ignores it) - Update MinIO example to use region: 'auto' - Add Tigris row to the endpoint values table Addresses review feedback from @ved015.
davidmyriel
force-pushed
the
myriel/s3-compatible
branch
from
aa4a60a to
3926808
Compare
Contributor
Author
|
@ved015 Vedant, I'm very sorry for the delay. I just sent over the changes as requested. Thank you! |
ved015
approved these changes
May 26, 2026
Member
|
@davidmyriel thank you for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there! Small docs fix for the S3 connector.
The
regionfield is marked required in the config table, but the S3-compatible examples (MinIO, R2, Spaces) never say what to put there. Since those services don't use AWS regions, users either guess an AWS region or get stuck wondering why the field is asking for something that doesn't apply to their setup.This PR:
region: 'auto'works for S3-compatible endpoints (the value is still needed for request signing, but the service ignores it)autoinstead ofus-east-1No code changes, no new pages, just making an existing doc a bit clearer. Happy to adjust wording if you'd rather keep the scope tighter.
Thanks for taking a look!